Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix send btn multiple clicks #3733

Closed
wants to merge 2 commits into from
Closed

fix send btn multiple clicks #3733

wants to merge 2 commits into from

Conversation

amiraabouhadid
Copy link
Contributor

@amiraabouhadid amiraabouhadid commented Dec 15, 2024 •
edited
Loading

Changes

  • added setting isValidTwinID and isValid address set to false to disable btn after form is submitted

Related Issues

#3684

Tested Scenarios

  • clicking on send btn multiple times does not result in multiple transactions
  • loading on btn starts after first click
  • only 1 transaction toast is shown

Checklist

@amiraabouhadid amiraabouhadid changed the base branch from development to development_2.7 December 15, 2024 09:50
@amiraabouhadid amiraabouhadid marked this pull request as ready for review December 15, 2024 09:51
@AhmedHanafy725 AhmedHanafy725 deleted the branch development_2.7 December 15, 2024 12:42
@amiraabouhadid amiraabouhadid deleted the dev_2.7_fix_send_btn branch December 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama approved these changes

@samaradel samaradel samaradel approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@zaelgohary zaelgohary Awaiting requested review from zaelgohary

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar

@0oM4R 0oM4R Awaiting requested review from 0oM4R

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amiraabouhadid @samaradel @maayarosama @AhmedHanafy725